chore(deps): widen peerDependencies for react and @hookform/devtools #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 28 28
Lines 391 391
Branches 125 125
=======================================
Hits 292 292
Misses 64 64
Partials 35 35 ☔ View full report in Codecov by Sentry. |
yfrommelt
approved these changes
May 13, 2024
hpierre74
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
When using theses packages with our app. The peerDependencies resolutions makes our package manager warn us about unmet peerDependencies.
We want to be able to use react-i18n with React 18.
We want to be able to use eslint-plugin-i18n.
💻 How?
We widen the peerDependencies specifier:
Motivation and Context
The peerDependencies resolutions makes our package manager warn us about unmet peerDependencies.
How Has This Been Tested?
It hasn't been tested 🤷
Types of changes
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to change)Checklist